just to double check to see if I am doing this correctly for random matchups:
I do it like this:
1) get a pokemon I need at lv1
It doesn't have to be level 1, as long as it hasn't participated in any battles (besides the one to capture it, if it was a capture).
2) everything above 100EV I use 10 proteins right away, the rest I do it with those wings... (I never enter a battle btw)
Unless you're using AR for infinite wings, then gaining EVs through battle will be much faster. See this article for more information. Otherwise, correct.
3) THEN, after I reach those EVs from the smogon articles/movesets, I then check with the white lady in Opelucid until she says 'great effort'.
Correct, but keep in mind that the spreads in the articles will only add up to 508 out of 510 EVs, because the last two are irrelevant - you'll need to put two more in a random stat before you get the "great effort" message.
4) then, i train it to lv50 (i use rare candies, or does it matter how i do it from here, is the spread the same?)
If you did the previous steps correctly, it doesn't matter; once a Pokémon gets 510 EVs, that will never change unless you use the EV-reducing berries.
5) at lv50, teach moves, tms, etc and max the PP and that's it
Correct, unless it evolves or learns a level-up move that you want at a level higher than 50.
is that a good way or bad way and WHY? thanks a lot, cause I need to know this, i don't want to waste my time if that's not the way it goes... thanks a lot :)